grafana_service_account: Require role attribute
#1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1493 The other option would've been to default to `None` BUT, the `None` role is only available from 10.3, so this would not work for most Grafana versions
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
K-Phoen
approved these changes
Apr 17, 2024
|
This is a backwards incompatible change, will it be released with a major version bump? |
Not specifying it gave a 500. Requiring a role is not backwards incompatible IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1493
The other option would've been to default to
NoneBUT theNonerole is only available from 10.3, so this would not work for most Grafana versions