Remove all deprecated attributes and resources #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
julienduchesne
force-pushed
the
julienduchesne/deprecations
branch
7 times, most recently
from
0950232 to
b07dc3e
Compare
julienduchesne
changed the title
gerboland
approved these changes
May 3, 2024
joeyorlando
approved these changes
May 3, 2024
There was a problem hiding this comment.
agree with getting rid of this, just curious if the next release be a major version bump? (as this feels like a breaking change)
There was a problem hiding this comment.
Yup. That will be in the 3.0.0
There was a problem hiding this comment.
I'll be merging all of the v3 milestone PRs at the same time. When I'm ready to do the major release
|
@julienduchesne is there a estimate as yo when the v3 of terraform will be out? |
|
Monday, I think |
Preparing the next major release, this PR removes deprecated attributes and resources Their use was also replaced with their non-deprecated alternative
julienduchesne
force-pushed
the
julienduchesne/deprecations
branch
from
b07dc3e to
354bfca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the next major release, this PR removes deprecated attributes and resources
Their use was also replaced with their non-deprecated alternative
Note: this is a pretty big PR, but there's nothing really crazy in there. Mostly removing some attributes and where they are plugged in. The one thing of note is a workaround I had to do in the annotations resource: https://github.com/grafana/terraform-provider-grafana/pull/1529/files#diff-2557a290b338e0264c77cd6aead40eb6907ee01698f66757b51e281a72df841aR134-R154