feat(slo): support folder field #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
|
👋 For some reason, the tests don't pass anymore when these changes are applied. I will investigate more tomorrow 👀 |
julienduchesne
added a commit
that referenced
this pull request
May 22, 2024
Pre-requisite for #1553
julienduchesne
added a commit
that referenced
this pull request
May 22, 2024
Pre-requisite for #1553
julienduchesne
force-pushed
the
feat/slo/support-folder-field
branch
from
1a12e2a to
359def9
Compare
|
LGTM! Thanks! |
julienduchesne
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order for users to be able to define folder for SLO resource, we need to upgrade github.com/grafana/slo-openapi-client to latest version. This mainly require changing the usage of
Slostruct toSloV00Slo. The new struct is generated by OpenAPI spec and since the API request function expect the versioned struct, it would be easier to use the new struct directly.Related to the folder input, the new field is called
folder_uidand it's optional.Tests
Local
The following tests has been conducted locally and applied in Grafana Cloud Enterprise account.
folder_uidfolder_uid