Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Generation: Sort resources and imports #1582

Merged
merged 3 commits into from
May 27, 2024

Conversation

julienduchesne
Copy link
Member

Depends on #1572

Implementing a test suite is difficult right now because the output is randomized
This sorts both the -imports.tf and the -resources.tf files being generated, leading to a predictable output!

This makes the generation code usable elsewhere than in the CLI
Next up: Nicer test suite
Implementing a test suite is difficult right now because the output is randomized
This sorts both the `-imports.tf` and the `-resources.tf` files being generated, leading to a predictable output!
@julienduchesne julienduchesne requested a review from a team as a code owner May 24, 2024 17:51
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne changed the base branch from julienduchesne/generation-lib to main May 27, 2024 01:05
@julienduchesne julienduchesne merged commit 568a1de into main May 27, 2024
24 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/generate-sort branch May 27, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants