Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: update url.UserPassword arguments to use TrimSpace #1704

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

rluisr
Copy link
Contributor

@rluisr rluisr commented Jul 22, 2024

Resolving the problem of an Invalid Header error when reading auth using the terraform file function, where newlines etc. are inserted at the end of the credential file in formats such as Prettier, VSCode(insertFinalNewline).

@rluisr rluisr requested a review from a team as a code owner July 22, 2024 13:37
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@rluisr rluisr changed the title fix: update url.UserPassword arguments to use TrimSpace API: update url.UserPassword arguments to use TrimSpace Jul 22, 2024
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable to me. Thanks!

@julienduchesne julienduchesne merged commit aa2bed3 into grafana:main Jul 22, 2024
18 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants