Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(slo): Fixing value description getting inappropriately attribued to all value tags #1720

Merged
merged 1 commit into from
Jul 26, 2024
Merged

docs(slo): Fixing value description getting inappropriately attribued to all value tags #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions docs/resources/slo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ Optional:

Required:

- `key` (String)
- `value` (String)
- `key` (String) Key for filtering and identification
- `value` (String) Templatable value


<a id="nestedblock--alerting--fastburn"></a>
Expand All @@ -235,17 +235,17 @@ Optional:

Required:

- `key` (String)
- `value` (String)
- `key` (String) Key for filtering and identification
- `value` (String) Templatable value


<a id="nestedblock--alerting--fastburn--label"></a>
### Nested Schema for `alerting.fastburn.label`

Required:

- `key` (String)
- `value` (String)
- `key` (String) Key for filtering and identification
- `value` (String) Templatable value



Expand All @@ -254,8 +254,8 @@ Required:

Required:

- `key` (String)
- `value` (String)
- `key` (String) Key for filtering and identification
- `value` (String) Templatable value


<a id="nestedblock--alerting--slowburn"></a>
Expand All @@ -271,17 +271,17 @@ Optional:

Required:

- `key` (String)
- `value` (String)
- `key` (String) Key for filtering and identification
- `value` (String) Templatable value


<a id="nestedblock--alerting--slowburn--label"></a>
### Nested Schema for `alerting.slowburn.label`

Required:

- `key` (String)
- `value` (String)
- `key` (String) Key for filtering and identification
- `value` (String) Templatable value



Expand All @@ -299,8 +299,8 @@ Optional:

Required:

- `key` (String)
- `value` (String)
- `key` (String) Key for filtering and identification
- `value` (String) Templatable value

## Import

Expand Down
10 changes: 6 additions & 4 deletions internal/resources/slo/resource_slo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,14 @@ Resource manages Grafana SLOs.
var keyvalueSchema = &schema.Resource{
Schema: map[string]*schema.Schema{
"key": {
Type: schema.TypeString,
Required: true,
Type: schema.TypeString,
Required: true,
Description: `Key for filtering and identification`,
},
"value": {
Type: schema.TypeString,
Required: true,
Type: schema.TypeString,
Required: true,
Description: `Templatable value`,
},
},
}
Expand Down
Loading