Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix listing oncall users when more than 1 page #2027

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

brojd
Copy link
Contributor

@brojd brojd commented Feb 11, 2025

Related to https://github.com/grafana/support-escalations/issues/14634

When public API of OnCall is hit from the TF provider, we always pass page=1. In the datasource code of the provider there's a loop that depends on the presence of next in paginated response. And it seems we don't bump the page so the next is always there causing infinite chain of requests

@brojd brojd requested review from a team as code owners February 11, 2025 12:50
@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but know that @grafana/platform-monitoring does not do gatekeeping, teams should feel empowered to get things merged on their own.

@brojd brojd merged commit 31f247d into main Feb 13, 2025
26 checks passed
@brojd brojd deleted the brojd/fix-listing-oncall-users branch February 13, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants