-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow alert notification reminder to be turned on #94
Conversation
Ping |
@chrisarcand Sorry to be a noodge, any estimate when somebody can look at this useful feature? |
Hi! This is a community provider, and I'm afraid I have no context to assist here; I believe either @mlclmj or @tonglil may be able to help though. Thanks! |
👋🏼 Sorry for the delay! I'll try to take a look at this later today. |
This looks great! Mind adding the new configuration options in the docs for alert notifications? |
Sure, I can take care of that tomorrow. |
Authored-by: John Shahid <[email protected]>
Authored-by: John Shahid <[email protected]>
I pushed two new commit to fix a typo and update the docs to make it easier to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Ping |
We are preparing a release, likely this week |
Ping |
I could really use this feature, will you be releasing soon? |
Note there is no default value for the
frequency
. Users will get an error if they setsend_reminder
to true and don't specify a value for thefrequency
.