Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alert notification reminder to be turned on #94

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

jvshahid
Copy link

Note there is no default value for the frequency. Users will get an error if they set send_reminder to true and don't specify a value for the frequency.

@ghost ghost added the size/M label May 12, 2020
@jvshahid
Copy link
Author

Ping

@Houlistonm
Copy link

@chrisarcand Sorry to be a noodge, any estimate when somebody can look at this useful feature?

@chrisarcand
Copy link

Hi!

This is a community provider, and I'm afraid I have no context to assist here; I believe either @mlclmj or @tonglil may be able to help though.

Thanks!

@mlclmj
Copy link
Contributor

mlclmj commented May 29, 2020

👋🏼 Sorry for the delay! I'll try to take a look at this later today.

@mlclmj
Copy link
Contributor

mlclmj commented May 30, 2020

This looks great! Mind adding the new configuration options in the docs for alert notifications?

@jvshahid
Copy link
Author

Sure, I can take care of that tomorrow.

John Shahid added 2 commits June 1, 2020 14:32
Authored-by: John Shahid <[email protected]>
@ghost ghost added the documentation label Jun 1, 2020
@jvshahid
Copy link
Author

jvshahid commented Jun 1, 2020

I pushed two new commit to fix a typo and update the docs to make it easier to
review. Feel free to squash the commits.

Copy link
Contributor

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tonglil tonglil merged commit 0e40d16 into grafana:master Jun 2, 2020
@jvshahid
Copy link
Author

jvshahid commented Jun 2, 2020

Thanks, @tonglil, and @mlclmj for reviewing and merging this PR. When should we expect the changes to be released? I am not very familiar with the community providers release cadence.

@jvshahid jvshahid deleted the notification-alert-reminders branch June 3, 2020 20:29
@jvshahid
Copy link
Author

jvshahid commented Jun 9, 2020

Ping

@tonglil
Copy link
Contributor

tonglil commented Jun 10, 2020

We are preparing a release, likely this week

@jvshahid
Copy link
Author

jvshahid commented Jul 2, 2020

Hi @tonglil and @mlclmj, I am curious if you are still planning to cut a new release with the above changes? Let me know if there is anything I can do to help.

@jvshahid
Copy link
Author

Ping

@Houlistonm
Copy link

I could really use this feature, will you be releasing soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants