fix: commonjs imports #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3925ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are not available as alpha, since there are no linked |
|
mts, cts, cgi madness |
kamilkisiela
reviewed
Aug 5, 2022
| @@ -274,6 +274,30 @@ async function build({ | |||
| join(distPath, "cjs", "package.json"), | |||
| JSON.stringify({ type: "commonjs" }) | |||
| ); | |||
| // We need to provide .cjs extension type definitions as well :) | |||
kamilkisiela
approved these changes
Aug 5, 2022
n1ru4l
force-pushed
the
fix-commonjs-imports
branch
from
bc45ad2 to
cceb28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ardatan/graphql-tools#4581 (comment) and microsoft/TypeScript#49299