Skip to content

Add the TrivialDataFetcher interface to MethodFieldResolver so that i… #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cliedeman
Copy link
Contributor

…t can be excluded from tracing

*
* Requirements are:
* prefixed with get
* must have zero parameters
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should become more strict and only return true for 'primitives'.

E.g. any actual primitives and String, Integer, Double etc and the java date/time objects.

or If the field returns a scalar. that should work too

@oliemansm oliemansm merged commit 0e4b8a9 into graphql-java-kickstart:master Jan 15, 2020
@oliemansm oliemansm added this to the 5.7.2 milestone Jan 15, 2020
@oliemansm oliemansm modified the milestones: 5.7.2, 6.0.0 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants