Skip to content

Tests fail out of the box. #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrSampson opened this issue Jan 2, 2024 · 2 comments
Closed

Tests fail out of the box. #457

MrSampson opened this issue Jan 2, 2024 · 2 comments
Labels
type: tests Adding missing or correcting existing tests

Comments

@MrSampson
Copy link

I wanted to make a small change, so I followed the contributing guidelines and:

make tests passes 100% but make all_tests fails on 18 tests.

Is this to be expected?

BTW, what I wanted to change is related to the aiohttp 3.9 restriction to python3.12 I'd like to change that to 3.11 since I'm unable to upgrade to 3.12 at the moment. aiohttp 3.9 is necessary due to the two CVEs that came out a month ago.

https://nvd.nist.gov/vuln/detail/CVE-2023-49081
https://nvd.nist.gov/vuln/detail/CVE-2023-49082

Thanks,
Oliver

@leszekhanusz leszekhanusz added the type: tests Adding missing or correcting existing tests label Jan 3, 2024
@leszekhanusz
Copy link
Collaborator

make tests passes 100% but make all_tests fails on 18 tests.
Is this to be expected?

Yes, make all_tests run some tests on a backend out of our control. That's why they are not part of the default tests as they could be flaky and the backend could change at any time.

I made the PR #459 to fix them for now.

See your PR for your other issue.

@MrSampson
Copy link
Author

Ah, cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tests Adding missing or correcting existing tests
Projects
None yet
Development

No branches or pull requests

2 participants