Skip to content

Fix online tests using the countries.trevorblades.com backend #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

leszekhanusz
Copy link
Collaborator

@leszekhanusz leszekhanusz commented Jan 2, 2024

The backend that we use for some online tests (countries.trevorblades.com) (not part of the default tests) is not affiliated to gql and is subject to changes out of our control.

Because of some of those changes, run with make all_tests were failing.

Changes:

  • the websocket backend is not available anymore (See issue countries#42)
  • the http endpoint is not available anymore, only the https endpoint works
  • batching is not supported anymore (See issue countries#72)
  • some returned error changed

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (039236c) 100.00% compared to head (0b43366) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #459   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         2619      2619           
=========================================
  Hits          2619      2619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leszekhanusz leszekhanusz merged commit c23d3e0 into graphql-python:master Jan 3, 2024
@leszekhanusz leszekhanusz deleted the fix_online_tests branch January 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant