Skip to content

websockets transport - optional variables and operation name #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions gql/transport/websockets.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,16 +243,14 @@ async def _send_query(
query_id = self.next_query_id
self.next_query_id += 1

payload: Dict[str, Any] = {"query": print_ast(document)}
if variable_values:
payload["variables"] = variable_values
if operation_name:
payload["operationName"] = operation_name

query_str = json.dumps(
{
"id": str(query_id),
"type": "start",
"payload": {
"variables": variable_values or {},
"operationName": operation_name or "",
"query": print_ast(document),
},
}
{"id": str(query_id), "type": "start", "payload": payload}
)

await self._send(query_str)
Expand Down
28 changes: 28 additions & 0 deletions tests/test_websocket_subscription.py
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,34 @@ async def test_websocket_subscription_slow_consumer(
assert count == -1


@pytest.mark.asyncio
@pytest.mark.parametrize("server", [server_countdown], indirect=True)
@pytest.mark.parametrize("subscription_str", [countdown_subscription_str])
async def test_websocket_subscription_with_operation_name(
event_loop, client_and_server, subscription_str
):

session, server = client_and_server

count = 10
subscription = gql(subscription_str.format(count=count))

async for result in session.subscribe(
subscription, operation_name="CountdownSubscription"
):

number = result["number"]
print(f"Number received: {number}")

assert number == count
count -= 1

assert count == -1

# Check that the query contains the operationName
assert '"operationName": "CountdownSubscription"' in logged_messages[0]


WITH_KEEPALIVE = True


Expand Down