Skip to content

Better transport exception messages #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

Add the answer received in some exceptions (TransportProtocolError and TransportServerError)

Should help for cases like #149

@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #155 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          927       929    +2     
=========================================
+ Hits           927       929    +2     
Impacted Files Coverage Δ
gql/transport/websockets.py 100.00% <ø> (ø)
gql/transport/aiohttp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d7d7f...b005bce. Read the comment docs.

Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small improvements but needed 🚀

@leszekhanusz leszekhanusz merged commit d7d871f into graphql-python:master Oct 24, 2020
@leszekhanusz leszekhanusz deleted the feature_more_details_in_transport_exceptions branch October 24, 2020 20:59
@leszekhanusz leszekhanusz added the type: feature A new feature label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants