Skip to content

Feature aiohttp and requests transports logging #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leszekhanusz
Copy link
Collaborator

@leszekhanusz leszekhanusz commented Oct 24, 2020

Add logging messages for the aiohttp and requests transport.

Also add a logging page in the docs

@codecov-io
Copy link

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          929       934    +5     
=========================================
+ Hits           929       934    +5     
Impacted Files Coverage Δ
gql/transport/aiohttp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183a291...1bb74c2. Read the comment docs.

@leszekhanusz leszekhanusz added type: feature A new feature type: documentation An issue or pull request for improving or updating the documentation labels Oct 25, 2020
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great but should RequestsHTTPTransport have logging features as well? If that's the case, it can be provided on another PR. 🚀

@leszekhanusz leszekhanusz changed the title Feature aiohttp logging Feature aiohttp and requests transports logging Oct 29, 2020
@leszekhanusz
Copy link
Collaborator Author

Everything looks great but should RequestsHTTPTransport have logging features as well? If that's the case, it can be provided on another PR. rocket

I added it in this one.

@leszekhanusz leszekhanusz merged commit 9d79b11 into graphql-python:master Oct 29, 2020
@leszekhanusz leszekhanusz deleted the feature_aiohttp_logging branch October 29, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating the documentation type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants