Skip to content

DOC add documentation on how to disable the transport logs #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

leszekhanusz
Copy link
Collaborator

Should help with issue #178

@codecov-io
Copy link

Codecov Report

Merging #183 (6c4eb0b) into master (c17959c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          949       949           
=========================================
  Hits           949       949           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17959c...6c4eb0b. Read the comment docs.

@leszekhanusz leszekhanusz added the type: documentation An issue or pull request for improving or updating the documentation label Dec 12, 2020
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Regarding the following statement:

When the query sent to the API is logged it contains a lot of new lines and spaces which damage the readibility.

At the linked issue, would be good to point out that this is on purpose as GraphQL schemas and queries have this formatting in order to be passed into the Parser/Lexer.

Maybe they expect a pretty printing of those JSON responses, which can be achieved very easily by using something like graphql-server does:

import json

json.dumps(data, indent=2, separators=(",", ": "))

@leszekhanusz leszekhanusz merged commit 459d5eb into graphql-python:master Dec 14, 2020
@leszekhanusz leszekhanusz deleted the doc_disable_logs branch December 14, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants