Skip to content

Invert the order of proposed subprotocols apollo and graphql-ws #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

Some websockets backend are incorrectly returning the first proposed protocol from the http_headers.

In that case, an error like this might be received:

websockets.exceptions.ConnectionClosedError: code = 1002 (protocol error), no reason

This PR should fix make all_tests with countries.trevorblades.com

Should fix make all_tests with countries.trevorblades.com
@codecov-commenter
Copy link

Codecov Report

Merging #265 (6a76c50) into master (75a771d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1763      1763           
=========================================
  Hits          1763      1763           
Impacted Files Coverage Δ
gql/transport/websockets.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a771d...6a76c50. Read the comment docs.

@leszekhanusz leszekhanusz merged commit 7f402c8 into graphql-python:master Nov 26, 2021
@leszekhanusz leszekhanusz deleted the fix_websockets_supported_protocols_order branch March 12, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants