Skip to content

Update type hint to align with docs and usage. #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaufi
Copy link
Contributor

@joaufi joaufi commented Dec 17, 2021

Description

Updated the type hint for the verify kwarg of RequestsHTTPTransport to align with both the class documentation and intended usage of verify.

Testing

All tests pass. I'm happy to write a test that verifies both a bool and a str can be provided as an arg to verify but that seemed a bit overkill to me as MyPy should cover such usages in application code.

@codecov-commenter
Copy link

Codecov Report

Merging #285 (dfd0d1c) into master (9b131a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2045      2045           
=========================================
  Hits          2045      2045           
Impacted Files Coverage Δ
gql/transport/requests.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b131a1...dfd0d1c. Read the comment docs.

@leszekhanusz leszekhanusz merged commit 6b51742 into graphql-python:master Dec 17, 2021
@leszekhanusz
Copy link
Collaborator

Thanks for your PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants