Skip to content

Saving http response headers reference in transports #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sondalex
Copy link
Contributor

@sondalex sondalex commented Feb 5, 2022

The purpose of this Pull Request is to add a request response header attribute. Accessing response header can be useful for retrieving rate limiting information from some APIs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

Merging #293 (ca098b1) into master (23c6f85) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2108      2115    +7     
=========================================
+ Hits          2108      2115    +7     
Impacted Files Coverage Δ
gql/transport/aiohttp.py 100.00% <100.00%> (ø)
gql/transport/requests.py 100.00% <100.00%> (ø)
gql/transport/websockets_base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c6f85...ca098b1. Read the comment docs.

@leszekhanusz
Copy link
Collaborator

Thanks for your PR! I added the reference to the other transports as well and added some tests and documentation.

@sondalex
Copy link
Contributor Author

Thank you for your reply and contributions! 😄

@leszekhanusz leszekhanusz changed the title gql/transports/requests.py add response header attribute Saving http response headers reference in transports Mar 10, 2022
@leszekhanusz leszekhanusz merged commit 074ca9e into graphql-python:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants