-
Notifications
You must be signed in to change notification settings - Fork 184
Close transport when fetching the schema failed #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close transport when fetching the schema failed #297
Conversation
Fetching the schema from the transport might fail with an exception. This Commit ensures that the transport is closed in such a case and the client object can be used to open a new session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Could you please also add two tests for sync and async ?
@leszekhanusz Thank you for the quick reply and review. I am on holiday over the weekend and will address everything on Monday. |
@leszekhanusz I added two tests and a comment why I catch the broad exception. Can you have a look at it again. Thank you! |
Thanks. Please read the CONTRIBUTING.md file to see how to fix linter errors (running |
@leszekhanusz Thanks for being so patient. Now all tests should pass and the coding guidelines are also respected. |
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2060 2068 +8
=========================================
+ Hits 2060 2068 +8
Continue to review full report at Codecov.
|
LGTM 🚀 |
Fetching the schema from the transport might fail with an exception. This Commit
ensures that the transport is closed in such a case and the client object can be
used to open a new session.