Skip to content

Allow to specify subprotocols in the websockets transport #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

It is currently necessary for the graphql-ws backend if the backend is not using the backwards-compatible version.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #300 (d3e88a0) into master (d3be916) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2070      2072    +2     
=========================================
+ Hits          2070      2072    +2     
Impacted Files Coverage Δ
gql/transport/websockets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3be916...d3e88a0. Read the comment docs.

@leszekhanusz leszekhanusz merged commit 5127e8c into graphql-python:master Feb 22, 2022
@leszekhanusz leszekhanusz deleted the websockets_transport_allow_to_specify_valid_subprotocols branch March 12, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants