Skip to content

Fix parsing of None with parse_results=True #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 4, 2022

Conversation

pvanderlinden
Copy link
Contributor

Demonstrates #325

@leszekhanusz
Copy link
Collaborator

Thanks, I'll take a look

@codecov-commenter
Copy link

Codecov Report

Merging #326 (ccc1c83) into master (64c9b5b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #326   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2158      2156    -2     
=========================================
- Hits          2158      2156    -2     
Impacted Files Coverage Δ
gql/utilities/parse_result.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c9b5b...ccc1c83. Read the comment docs.

@leszekhanusz leszekhanusz changed the title test: parse mapping Fix parsing of None with parse_results=True May 3, 2022
@leszekhanusz
Copy link
Collaborator

I'll merge this PR once you confirm that everything is OK for you with your tests.

@pvanderlinden
Copy link
Contributor Author

I'll merge this PR once you confirm that everything is OK for you with your tests.

Just tested it, and it is working as expected now 👍

@leszekhanusz leszekhanusz merged commit 321c606 into graphql-python:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants