Skip to content

Make AsyncTransport and Transport proper abstract base classes #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Make AsyncTransport and Transport proper abstract base classes #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c38caf
Update async_transport.py
willfrey Aug 4, 2022
1842969
Update transport.py
willfrey Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gql/transport/async_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from graphql import DocumentNode, ExecutionResult


class AsyncTransport:
class AsyncTransport(abc.ABC):
@abc.abstractmethod
async def connect(self):
"""Coroutine used to create a connection to the specified address"""
Expand Down
2 changes: 1 addition & 1 deletion gql/transport/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from graphql import DocumentNode, ExecutionResult


class Transport:
class Transport(abc.ABC):
@abc.abstractmethod
def execute(self, document: DocumentNode, *args, **kwargs) -> ExecutionResult:
"""Execute GraphQL query.
Expand Down