remove JSONField compat #1421
Merged
remove JSONField compat #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🌷 (except the pre-commit error) |
|
@ulgens fixed 😉 |
ulgens
approved these changes
Jun 7, 2023
firaskafri
approved these changes
Jun 7, 2023
sjdemartini
reviewed
Jun 7, 2023
| from django.db.models import JSONField | ||
| except ImportError: | ||
| JSONField = MissingType | ||
| IntegerRangeField, ArrayField, HStoreField, RangeField = (MissingType,) * 5 |
There was a problem hiding this comment.
Looks like this should be * 4 now instead
There was a problem hiding this comment.
Since this was merged, I added a separate quick PR for this #1423
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
* remove JSONFIeld compat * fix black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 3.1 introduced universal JSONFIeld so compatibility is no longer required because we support Django 3.2 or above.