Updated Django Filter integration to 1.0 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Why did you do this? |
|
@Svoka could be possible to know what you mean exactly? Was this PR (from 2016) causing some regression on your side? |
|
@syrusakbary somehow yes. We are in process of updating old deps and now we have to implement it. I don't follow much, but maybe you have something like roadmap or blog post where you explaining why you decide to remove this features? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the integration with Django Filter, deprecating the usage of
order_byandfilter_order_byin Graphene Django.The only compatible
django-filterversion will be1.0and above, if your project requiresdjango-filter0.1Xplease usegraphene-django<="1.1"