Skip to content

BUG: Out of Sync with graphql-relay > 3.1 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ed-turner opened this issue Jan 27, 2022 · 4 comments
Closed

BUG: Out of Sync with graphql-relay > 3.1 #329

ed-turner opened this issue Jan 27, 2022 · 4 comments

Comments

@ed-turner
Copy link

This is related to the import graphql_relay.connection.arrayconnection in graphene_sqlalchemy.fields.SQLAlchemyConnectionField.

To reproduce:

  1. pip install graphql-relay==3.1.0
  2. Run from graphene_sqlalchemy.fields import SQLAlchemyConnectionField
  3. You will get an import module error for graphql_relay.connection.arrayconnection

One suggestion is to either make specific requirements for graphql-relay in the install requirements or update the imports in the 3.0 release.
@Cito
Copy link
Member

Cito commented Jan 28, 2022

There will be a patch release of graphql-relay 3.1 for backward compatibility today, but it should also be fixed here by importing from the top level of graphql-relay.

@Cito
Copy link
Member

Cito commented Jan 28, 2022 •
edited
Loading

A patch-release graphql-relay 3.1.5 has been released now and a fix for graphene-sqlalchemy has been posted as PR #330.

erikwrede pushed a commit that referenced this issue Apr 27, 2022
@Cito
Fix for import from graphql-relay-py (#329) (#330)
771f4f5 
* Add newlines to make pre-commit happy

* Fix import from graphql_relay

The module name was deprecated, but all imports
should be made from the top level anyway.
@erikwrede
Copy link
Member

I've just merged the PR, this should be fixed once someone with PyPi access pushes a release!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics referencing this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Cito @erikwrede @ed-turner