Skip to content

Add additional sqlalchemy_utils types #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ianepperson
Copy link
Contributor

This change adds most of the trivial string types from sqlalchemy_utils:
UUIDType, EmailType, URLType, and IPAddressType.

@coveralls
Copy link

coveralls commented Apr 22, 2020

Coverage Status

Coverage decreased (-97.6%) to 0.0% when pulling 143418e on ianepperson:master into 20ecaea on graphql-python:master.

@ianepperson
Copy link
Contributor Author

Coverage Status

Coverage decreased (-0.2%) to 97.427% when pulling de42c7c on ianepperson:master into 421f8e4 on graphql-python:master.

Meh, it's likely the import statement that's making the coverage drop. I think there's a better way to do that.

Add most trivial string types from sqlalchemy_utils:
UUIDType, EmailType, URLType, and IPAddressType
@ianepperson
Copy link
Contributor Author

Hey @jnak , that last change fixed the unit tests, can I get a review of this when you've got a chance?
Thanks!

@erikwrede
Copy link
Member

Added all contents of this (except for geoalchemy) to #353. Thank you for the work!

@erikwrede erikwrede closed this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants