Adds __eq__ and test of it #1181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
requested review from
dan98765,
ekampf,
jkimbo and
ProjectCheshire
as code owners
spacether
force-pushed
the
feat_adds_eq_method
branch
from
a222371 to
c5fcb52
Compare
|
We just merged #1157, which indirectly added support for Could test without the |
|
This PR is no longer needed because #1157 added the eq method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
__eq__method to the ObjectType class so instances of it can be comparedTests of the new method has also been added.
Happy to add more tests my guess is that we may need to cover more use cases.
If merged, this will close out this issue