Skip to content

Move async methods into class methods #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Oct 16, 2021

@Cito I've started moving the async methods into class methods to see if it will improve performance (#142 )

Unfortunately it doesn't seem to have improved things (0001_class_m is this branch and NOW is main):
CleanShot 2021-10-16 at 11 59 23@2x

I don't think its worth carrying on with this change. What do you think?

@jkimbo jkimbo requested a review from Cito October 16, 2021 11:01
@Cito
Copy link
Member

Cito commented Oct 16, 2021

Yes, it looks like defining the functions outside makes things even worse (maybe because the function name is not local any more). I was not sure about that, so it's good we know now.

The next step would be to create an execution context that assumes every resolver is async and is optimized for that case, and see if that can improve performance significantly.

Sorry, I'm currently too busy with other work and cannot help much. But I will also work on this eventually if nobody else does.

@Cito Cito force-pushed the main branch 3 times, most recently from 0ac79de to 3f40fc2 Compare November 7, 2021 20:26
@Cito
Copy link
Member

Cito commented Dec 28, 2021

Closing this now, thanks for trying. Mentioned the outcome in #142.

@Cito Cito closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants