Skip to content

v3.1.3 is incompatible with graphql-core v3.1.x #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobbyrenwick opened this issue Jan 22, 2022 · 2 comments
Closed

v3.1.3 is incompatible with graphql-core v3.1.x #43

bobbyrenwick opened this issue Jan 22, 2022 · 2 comments
Assignees

Comments

@bobbyrenwick
Copy link

Using [email protected] and [email protected] gives some import errors:

2022-01-22 14:12:02,961 P3528 [INFO]        from graphene import UUID, Enum
2022-01-22 14:12:02,961 P3528 [INFO]      File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/graphene/__init__.py", line 2, in <module>
2022-01-22 14:12:02,961 P3528 [INFO]        from .relay import (
2022-01-22 14:12:02,961 P3528 [INFO]      File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/graphene/relay/__init__.py", line 1, in <module
>
2022-01-22 14:12:02,961 P3528 [INFO]        from .node import Node, is_node, GlobalID
2022-01-22 14:12:02,961 P3528 [INFO]      File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/graphene/relay/node.py", line 4, in <module>
2022-01-22 14:12:02,962 P3528 [INFO]        from graphql_relay import from_global_id, to_global_id
2022-01-22 14:12:02,962 P3528 [INFO]      File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/graphql_relay/__init__.py", line 7, in <module>
2022-01-22 14:12:02,962 P3528 [INFO]        from .connection.connection import (
2022-01-22 14:12:02,962 P3528 [INFO]      File "/var/app/venv/staging-LQM1lest/lib/python3.7/site-packages/graphql_relay/connection/connection.py", line 3
, in <module>
2022-01-22 14:12:02,962 P3528 [INFO]        from graphql import (
2022-01-22 14:12:02,962 P3528 [INFO]    ImportError: cannot import name 'GraphQLNamedOutputType' from 'graphql' (/var/app/venv/staging-LQM1lest/lib/python
3.7/site-packages/graphql/__init__.py)

This commit added the line that's failing:
bb5f935#diff-b895c3c5263fde224cc02c9d85e98cb6e094c323260e8ea7900db89df72a17a6R13

The release notes say that it should be "compatible with graphql-core version 3.1.".

It seems that's not the case. The exporting of happened in graphql-python/graphql-core@5b9a728, which seems to be only available in 3.2.

For now I've worked around this by locking to an earlier version of graphql-relay-py and I'm not sure of the exact approach you'd want to use for fixing the problem. Perhaps changing install_requires in setup.py?

@Cito
Copy link
Member

Cito commented Jan 22, 2022

Thanks for reporting. You're right, it is unfortunately only compatible with the latest 3.1 version which is 3.1.7. Will try to fix that.

@Cito
Copy link
Member

Cito commented Jan 22, 2022

Should be fixed now in 3.1.4. Compatibility with graphql-core 3.2 will be provided by graphql-relay-core 3.2.

@Cito Cito closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants