Skip to content

Document the contextValue argument #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Document the contextValue argument #1400

merged 2 commits into from
Jun 29, 2018

Conversation

Cito
Copy link
Member

@Cito Cito commented Jun 21, 2018

No description provided.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

src/graphql.js Outdated
@@ -36,6 +36,10 @@ import type { MaybePromise } from './jsutils/MaybePromise';
* rootValue:
* The value provided as the first argument to resolver functions on the top
* level type (e.g. the query object type).
* contextValue:
* The context value is provided as the second argument to resolver
Copy link
Member

@IvanGoncharov IvanGoncharov Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be similar to this:

which will get passed to all resolve functions

https://graphql.org/graphql-js/graphql/#graphql

A little bit more
@leebyron leebyron merged commit c165907 into graphql:master Jun 29, 2018
@leebyron
Copy link
Contributor

Awesome thanks for improving documentation!

@Cito Cito deleted the graphql-document-context-value branch June 29, 2018 10:15
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Jun 29, 2018
IvanGoncharov added a commit that referenced this pull request Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants