Fix typo in AST predicates #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmahone
commented
Aug 12, 2018
| @@ -29,6 +28,7 @@ export const Kind = Object.freeze({ | |||
| FRAGMENT_DEFINITION: 'FragmentDefinition', | |||
|
|
|||
| // Values | |||
| VARIABLE: 'Variable', | |||
There was a problem hiding this comment.
Moved this to prevent future confusion
mjmahone
commented
Aug 12, 2018
| node.kind === Kind.INT || | ||
| node.kind === Kind.FLOAT || | ||
| node.kind === Kind.STRING || | ||
| node.kind === Kind.BOOLEAN || | ||
| node.kind === Kind.NULL || | ||
| node.kind === Kind.ENUM || | ||
| node.kind === Kind.LIST || | ||
| node.kind === Kind.OBJECT || | ||
| node.kind === Kind.OBJECT_FIELD |
There was a problem hiding this comment.
OBJECT_FIELD is lumped with Values in kinds.js, but that's because it doesn't really belong anywhere else. However, if I give an ObjectFieldNode to a function expecting a ValueNode, we've messed something up.
IvanGoncharov
approved these changes
Aug 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an easy mistake to make: the ordering in the
Kindobject made it seem likeVariablebelonged withVariableDefinition, when in fact it belongs with the values (as a variable definition defines that a value can be used).Additionally,
ObjectFieldis not itself a value: it's more of a key-value pair that itself contains a value.