[validator] Add suggested types to incorrect field message #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops I opened this off a super old |
dschafer
force-pushed
the
errormessage
branch
from
e27ac7a to
0da6740
Compare
|
Okay, rebased. |
dschafer
force-pushed
the
errormessage
branch
2 times, most recently
from
1eab039 to
efa9942
Compare
| { message: 'Cannot query field "isHousetrained" on "Dog".' } | ||
| { message: 'Cannot query field "catOrDog" on type "QueryRoot".' }, | ||
| { message: 'Cannot query field "furColor" on type "Cat".' }, | ||
| { message: 'Cannot query field "isHousetrained" on type "Dog".' } |
There was a problem hiding this comment.
maybe these 3 should actually be calls to undefinedField to match the other tests?
There was a problem hiding this comment.
Probably; if we do so, I definitely need to add a dedicated test for undefinedField (I'll do that anyway).
There was a problem hiding this comment.
Actually, I'll keep this as a true "integration" test.
|
This is awesome! Some minor feedback inline, but otherwise this is a huge upgrade on the error quality for this particular validator. |
dschafer
force-pushed
the
errormessage
branch
from
efa9942 to
7861b22
Compare
|
Updated with @leebyron feedback. |
dschafer
added a commit
that referenced
this pull request
Feb 2, 2016
[validator] Add suggested types to incorrect field message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the error message for
undefinedFieldto take in a list of suggested type names.