Skip to content

Type "must not be {null}" -> "must exist" #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Type "must not be {null}" -> "must exist" #1134

merged 1 commit into from
Mar 7, 2025

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 10, 2025

Minor editorial fix, we use "must exist" throughout the spec, and in this case it's appropriate to use "must exist" rather than "must not be null".

@benjie benjie added the ✏️ Editorial PR is non-normative or does not influence implementation label Feb 10, 2025
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 1ab78d0
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/67aa33d44d2a4100071ee80a
😎 Deploy Preview https://deploy-preview-1134--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better terminology 🤩 👍

@benjie benjie merged commit b7c57ea into main Mar 7, 2025
9 checks passed
@benjie benjie deleted the type-must-exist branch March 7, 2025 17:14
@github-project-automation github-project-automation bot moved this from SHIP IT to Done in Benjie's GraphQL tasks Mar 7, 2025
martinbonnin pushed a commit to martinbonnin/graphql-spec that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants