Input Union RFC: Move Requirements to "Criteria" #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryseed
changed the title
benjie
approved these changes
Oct 15, 2019
This was referenced Oct 15, 2019
|
I propose to name the section Criteria. I think criteria is fitting, as that includes all of aims, nice-to-haves, hard requirements, anti-goals. It is just a list of things to consider, by which we can judge the proposed solutions. |
Co-Authored-By: Benjie Gillam <[email protected]>
binaryseed
changed the title
jturkel
reviewed
Oct 15, 2019
jturkel
reviewed
Oct 17, 2019
spawnia
approved these changes
Oct 18, 2019
|
|
||
| ### Input polymorphism matches output polymorphism | ||
|
|
||
| Any data structure that can be modeled with output type polymorphism should be able to be mirrored with Input polymorphism. Minimal transformation of outputs should be required to send a data structure back as inputs. |
There was a problem hiding this comment.
@binaryseed I personally object to this one since GraphQL was never about CRUD.
Moreover, it's perfectly normal to have two distinct type systems, for example, most the programming languages have classes (support polymorphism) and structs (doesn't support polymorphism at the same time). To not block I will try to summarise my objection into Objection note and submit as a separate PR.
|
@binaryseed Sorry for delay and thanks for reaching out on Slack 👍 |
leebyron
added
the
📣 RFC document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the last Working Group meeting, this PR converts the "Requirements" section to an "Aims" section.
This is inline with the purpose of this document which is to gather all perspectives on the issue.
I've also added a few basic aims, one of which has an "objection"
@leebyron @IvanGoncharov @benjie