-
Notifications
You must be signed in to change notification settings - Fork 232
[2021-04-01] Scan GraphQL org for outdated (Facebook) copyright notices #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Remaining:
Need to do final scan |
I did a spot check and the copyright lines look alright to me. We generally don't require those to be changed and in fact, nobody else can/should change Facebook's copyright line other than an authorized person from the company. We generally recommend projects follow Steve Winslow's writeup on the topic. The good news is, it can stay as it is and be totally fine. That said, if some enterprising person wanted to add an additional copyright line that says "Copyright GraphQL contributors" (note there's no year in there), it'll be evergreen and won't ever need to be revved. That said, we should have a look at the license files in these two repos. And by "we", I mean, "I"... I can take this one, @IvanGoncharov. I'll reassign it to myself. |
See graphql/graphql-wg#662 for context. This is a very focused change. Note that there are still a few code files which are "Copyright Facebook". I personally wrote those original files and haven't bothered changing them. (See why: https://www.linuxfoundation.org/blog/copyright-notices-in-open-source-software-projects/) However future code and usage is governed by our LICENSE file, which we standardize as MIT including a general "Copyright (c) GraphQL Contributors". Same as our other repositories
See graphql/graphql-wg#662 for context. This is a very focused change. Note that there are still a few code files which are "Copyright Facebook". I personally wrote those original files and haven't bothered changing them. (See why: https://www.linuxfoundation.org/blog/copyright-notices-in-open-source-software-projects/) However future code and usage is governed by our LICENSE file, which we standardize as MIT including a general "Copyright (c) GraphQL Contributors". Same as our other repositories
Thanks for that link, fascinating read! I scanned through our repos looking specifically at the LICENSE files and found some variation which I cleaned up to all use the same MIT copy and evergreen copyright notice. I left individual files alone, as suggested |
Note: Action Item issues are reviewed and closed during Working Group
meetings.
The text was updated successfully, but these errors were encountered: