Skip to content

Add security policy to GraphQL-TSC.md #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Add security policy to GraphQL-TSC.md #881

merged 2 commits into from
Feb 7, 2022

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 3, 2022

As discussed in https://github.com/graphql/tsc/discussions/5 and #825, this text was proposed by @brianwarner and has been lightly edited by myself.

According to making changes to this document:

Pull requests against this document that do not conflict with the Technical Charter can be merged provided the following conditions have been met:

  • There are no outstanding objections
  • There are two approvals by TSC members (not including the author)
  • The PR has been open for at least 72 hours

TL;DR: this PR can be merged after 2022-02-06T14:40:00Z assuming it gets two approvals and no objections

@benjie benjie requested a review from a team February 3, 2022 14:39
GraphQL-TSC.md Outdated
@@ -286,6 +286,16 @@ If consensus cannot be reached, a pull request may still be landed after a vote

An exception is made for errata or to update meeting logistics. These may be landed immediately, provided all EasyCLA checks have passed.

### Security policy

The GraphQL TSC is in an elevated position of trust within the GraphQL community. Security concerns that impact repos under the [`graphql` GitHub org](https://github.com/graphql/) (including reference implementations and official tools) may be responsibly disclosed to the TSC via [any current TSC member](https://github.com/graphql/graphql-wg/blob/main/GraphQL-TSC.md#tsc-members-1), with the expectation that they will be discussed and triaged by the TSC as a whole.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianwarner should we set up an email alias to have a more clear disclosure guidance?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. "[email protected]"? Maybe going to you and the operations@ alias?

In my experience these tend to attract a lot of spam and emails from bug bounty farms, so it probably makes sense going to someone who can triage before passing it along.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This email is up and running if you want to swap this language @benjie

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@leebyron leebyron merged commit 33a4fb2 into main Feb 7, 2022
@leebyron leebyron deleted the tsc-security-policy branch February 7, 2022 18:04
@quapka
Copy link

quapka commented Feb 7, 2022

Hi folks!

Have you considered adding a SECURITY.md file to the respective repositories? Landing here when looking for a security policy in one of the /graphql/* projects seems still non-trivial.

The same goes for the main website. Seems worth linking from contacts page to the policy.

@benjie
Copy link
Member Author

benjie commented Feb 9, 2022

I have one open for spec here: graphql/graphql-spec#930 but it might make sense to create it in the https://github.com/graphql/.github repo instead so it automatically applies to all repos (but can still be overridden if desired).

What do you think @graphql/tsc?

sueannioanis pushed a commit to sueannioanis/graphql-wg that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants