Remove Express GraphQL
#1347
Merged
Remove Express GraphQL
#1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tuval Simha <[email protected]>
|
now that express-graphql has been deprecated, it might be good to remove it from the recommended frameworks |
|
Rather than deleting it (breaking permalinks, etc) can I suggest that we just change it to deprecated and remove copy saying it's the reference? Maybe even point to graphql-http from it? |
|
@benjie in this case, it will just remove express-graphql from the list of tools, not from tutorials and guides, so I don't think it breaks any permalinks? |
|
Ah; I had assumed it was linkable content. If it's not then sure 👍 |
|
Works for me. @Urigo I trust you to merge changes like this if you think they are right 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tuval Simha [email protected]
Closes #
Description
Remove Express GraphQL md file.
@Urigo