fix: learn pages crashing due to codemirror #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
sorry to ping you @TuvalSimha but maybe you can check since I'm reverting some of your changes here |
|
thank you so much @dannyhw! @TuvalSimha let's open another PR with a fix including the latest version |
|
@Urigo happy to help, this website has been really helpful for me :). Thanks for merging so quick, now I can get back to learning 🤓 |
|
@dannyhw thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1400
Description
I noticed that some things broke on /learn due to codemirror changes
After looking into it a bit code mirror 6 has breaking changes and updating it without adjusting implementation causes the learn pages to crash
I reverted some changes from 3db0010 and it seems to work again
test by visiting the learn queries/mutations page
heres the codemirror migration guide
https://codemirror.net/docs/migration/