new GraphQL website blog post #1692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dimaMachina is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @dimaMachina; please can you split the website refactoring work into its own PR so that the blog post PR is just the one file? |
dimaMachina
force-pushed
the
new-website-blog
branch
from
fb0e806 to
7158075
Compare
|
@benjie done! |
benjie
reviewed
Jun 8, 2024
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
Comment on lines
95
to
96
| The new website has a better bundle size and first load time compared to the | ||
| previous version. |
There was a problem hiding this comment.
If you have any numbers on this (reduced by X% and now loads Y times faster), that would be a great addition. No worries if not!
There was a problem hiding this comment.
I tried and I don't know how to properly measure this transition between Gatsby and Next.js, so I just completely removed this paragraph
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/blog/2024-06-08-announcing-new-graphql-website/index.mdx
Outdated
Show resolved
Hide resolved
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
….mdx Co-authored-by: Benjie <[email protected]>
benjie
approved these changes
Jun 8, 2024
Urigo
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be merged after #1714