Skip to content

GraphQL Local Initiative #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2024
Merged

GraphQL Local Initiative #1725

merged 6 commits into from
Aug 15, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Jul 10, 2024

No description provided.

@benjie benjie requested a review from jorydotcom July 10, 2024 16:21
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io 🛑 Canceled (Inspect) Aug 15, 2024 9:20am

Copy link
Contributor

@jorydotcom jorydotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments / thoughts to refine this a little!

@benjie
Copy link
Member Author

benjie commented Jul 17, 2024

Thanks for the input @jorydotcom! I think I've addressed your feedback, and also added another couple minor changes - let me know what you think? (It's all in that last commit.) In particular based on feedback by @jemgillam I wanted to make it explicit that we support both new and existing meets.

@bignimbus
Copy link
Contributor

LGTM!

@jorydotcom jorydotcom marked this pull request as ready for review July 29, 2024 15:39
@benjie benjie merged commit bdd9ebd into source Aug 15, 2024
4 checks passed
@benjie benjie deleted the local-initiative branch August 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants