Label mini GraphiQL panels. #1796
Conversation
|
@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return <div className="query-editor" ref={e => (this.domNode = e)} /> | ||
| return ( | ||
| <div className="query-editor" ref={e => (this.domNode = e)}> | ||
| <span className="editor-name">Operation</span> |
There was a problem hiding this comment.
Technically this is a "document" since it may contain fragments and multiple operations; but I think that's probably a little too technical for people learning the technology so I think you've made the right choice of term here 👍
|
@benjie feel free to apply my suggestions to make it perfect ;) |
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>
|
I'm not sure if this PR is the reason, but the descriptions of the mini graphiql do not disappear ones shown: |
|
Doesn't seem to be related; I've looked at the preview of #1765 which predates this change and it has the same issue. I think it's been an issue for a long time. |
|
Yeah, we need improve mini graphiql at some time |
Partially addresses #250 (addresses the second bullet point, a subsequent PR will address the first)
Description
This PR adds labels to each panel in the mini GraphiQL editors to help disambiguate the different elements of the code examples (Operation, Variables, and Response).