Skip to content

Update README.md #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 25, 2020
Merged

Update README.md #979

merged 11 commits into from
Nov 25, 2020

Conversation

Deepak-du
Copy link
Contributor

Readme file has been updated in a detailed way.

Readme file has been updated in a detailed way.
@Deepak-du
Copy link
Contributor Author

can you review this please @orta

Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to update the README 🙌🏼 🎉 It's great to give more context to what this repo contains and what's available through graphql.org.

Overall, I like the structure - but added some suggestions as far as word choice 😊

README.md Outdated
Comment on lines 5 to 8
**GraphQL 🎉** is a query language for APIs and a runtime for fulfilling those queries with your existing data.

Check out our [contributing guide](./CONTRIBUTING.md) for detailed instructions for how to make changes to graphql.org 🎉 No newline at end of file
**GraphQL 🎉** provides a complete and understandable description of the data in your API, gives clients the power to ask for exactly what they need and nothing more, makes it easier to evolve APIs over time, and enables powerful developer tools.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why have two descriptions instead of merging them into one?

Deepak-du and others added 5 commits November 25, 2020 17:52
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put all of my other suggestions into proper commit suggestions as that might be easier to work with. If you disagree or want to discuss any, please say so! I'm not super attached to any of these changes so happy to discuss 😊

Deepak-du and others added 5 commits November 25, 2020 22:17
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
@Deepak-du
Copy link
Contributor Author

Deepak-du commented Nov 25, 2020

Thanks for correcting me @carolstran😊 also
Assign me if you can 🚀

@Deepak-du Deepak-du requested a review from carolstran November 25, 2020 16:57
Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you 🎊

@carolstran carolstran merged commit ef51a05 into graphql:source Nov 25, 2020
Urigo pushed a commit that referenced this pull request Jan 26, 2021
* Update README.md

Readme file has been updated in a detailed way.

* Update README.md

Co-authored-by: Michael Esteban <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

* Update README.md

Co-authored-by: Carolyn Stransky <[email protected]>

Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants