-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update README.md #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #979
Conversation
Readme file has been updated in a detailed way.
can you review this please @orta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking the time to update the README 🙌🏼 🎉 It's great to give more context to what this repo contains and what's available through graphql.org.
Overall, I like the structure - but added some suggestions as far as word choice 😊
README.md
Outdated
**GraphQL 🎉** is a query language for APIs and a runtime for fulfilling those queries with your existing data. | ||
|
||
Check out our [contributing guide](./CONTRIBUTING.md) for detailed instructions for how to make changes to graphql.org 🎉 No newline at end of file | ||
**GraphQL 🎉** provides a complete and understandable description of the data in your API, gives clients the power to ask for exactly what they need and nothing more, makes it easier to evolve APIs over time, and enables powerful developer tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why have two descriptions instead of merging them into one?
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put all of my other suggestions into proper commit suggestions as that might be easier to work with. If you disagree or want to discuss any, please say so! I'm not super attached to any of these changes so happy to discuss 😊
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Co-authored-by: Carolyn Stransky <[email protected]>
Thanks for correcting me @carolstran😊 also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thank you 🎊
* Update README.md Readme file has been updated in a detailed way. * Update README.md Co-authored-by: Michael Esteban <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> * Update README.md Co-authored-by: Carolyn Stransky <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Carolyn Stransky <[email protected]>
Readme file has been updated in a detailed way.