Feat(defaultRequestTimeout) add defaultRequestTimeout property for the client #1132

batsura-sa · 2024-08-03T12:34:39Z

Hi! Could we add deadline property for client? @ST-DDT who will do review? what I'am doing wrong?

...ent-spring-boot-starter/src/main/java/net/devh/boot/grpc/client/deadline/DeadlineHelper.java

...pring-boot-starter/src/main/java/net/devh/boot/grpc/client/config/GrpcChannelProperties.java

tests/src/test/java/net/devh/boot/grpc/test/setup/DeadlineTests.java

...ent-spring-boot-starter/src/main/java/net/devh/boot/grpc/client/deadline/DeadlineHelper.java

...rter/src/main/java/net/devh/boot/grpc/client/interceptor/DeadlineSetupClientInterceptor.java

...pring-boot-starter/src/main/java/net/devh/boot/grpc/client/config/GrpcChannelProperties.java

...c/main/java/net/devh/boot/grpc/client/autoconfigure/GrpcClientDeadlineAutoConfiguration.java

…pc/client/config/GrpcChannelProperties.java Co-authored-by: ST-DDT <[email protected]>

...rter/src/main/java/net/devh/boot/grpc/client/interceptor/DeadlineSetupClientInterceptor.java

...c/main/java/net/devh/boot/grpc/client/autoconfigure/GrpcClientDeadlineAutoConfiguration.java

… runtime

...rter/src/main/java/net/devh/boot/grpc/client/interceptor/DeadlineSetupClientInterceptor.java

…pc/client/interceptor/DeadlineSetupClientInterceptor.java Co-authored-by: ST-DDT <[email protected]>

…cChannelConfigurer

ST-DDT

Looks good to me. Only a few small changes, and then this is good to go.

...c/main/java/net/devh/boot/grpc/client/autoconfigure/GrpcClientDeadlineAutoConfiguration.java

tests/src/test/java/net/devh/boot/grpc/test/setup/DeadlineTests.java

...pring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json

...pring-boot-starter/src/main/java/net/devh/boot/grpc/client/config/GrpcChannelProperties.java

genuss · 2024-09-05T09:19:03Z

What do you think about calling the configured property timeout instead of deadline? I believe the current name create some confusion. Deadline in context of GRPC has special meaning and that is "An absolute point in time", although the configured property is a duration.

…pc/client/autoconfigure/GrpcClientDeadlineAutoConfiguration.java Co-authored-by: ST-DDT <[email protected]>

batsura-sa · 2024-09-06T07:03:29Z

OK. For example grpc.client.GLOBAL.timeout=1s ? right?

Exactly 👍

Done, not sure about the names. We can improve the source code or comments if you think it is necessary.

...rc/main/java/net/devh/boot/grpc/client/autoconfigure/GrpcClientTimeoutAutoConfiguration.java

...arter/src/main/java/net/devh/boot/grpc/client/interceptor/TimeoutSetupClientInterceptor.java

...pring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json

tests/src/test/java/net/devh/boot/grpc/test/setup/TimeoutSetupTests.java

…pc/client/autoconfigure/GrpcClientTimeoutAutoConfiguration.java Co-authored-by: ST-DDT <[email protected]>

…pc/client/interceptor/TimeoutSetupClientInterceptor.java Co-authored-by: ST-DDT <[email protected]>

…ditional-spring-configuration-metadata.json Co-authored-by: ST-DDT <[email protected]>

batsura-sa · 2024-09-06T10:14:02Z

May be rename the timeout property to requestTimeout? Like this "grpc.client.GLOBAL.requestTimeout=1s". IMHO timeout is really abstract property name.

ST-DDT · 2024-09-06T10:33:02Z

May be rename the timeout property to requestTimeout? Like this "grpc.client.GLOBAL.requestTimeout=1s". IMHO timeout is really abstract property name.

requestTimeout or defaultRequestTimeout?

batsura-sa · 2024-09-06T10:39:17Z

May be rename the timeout property to requestTimeout? Like this "grpc.client.GLOBAL.requestTimeout=1s". IMHO timeout is really abstract property name.

requestTimeout or defaultRequestTimeout?

I like both, can you choose one? May be defaultRequestTimeout is better.

ST-DDT · 2024-09-06T11:04:11Z

I like both, can you choose one? May be defaultRequestTimeout is better.

Then defaultRequestTimeout it is.

…imeout

batsura-sa · 2024-09-06T16:42:58Z

I like both, can you choose one? May be defaultRequestTimeout is better.

Then defaultRequestTimeout it is.

Done. Please let me know if we can do comments or code better.

...pring-boot-starter/src/main/java/net/devh/boot/grpc/client/config/GrpcChannelProperties.java

…pc/client/config/GrpcChannelProperties.java Co-authored-by: ST-DDT <[email protected]>

ST-DDT

Looks good to me.
Thanks for your contribution. ❤️

batsura-sa · 2024-09-07T08:24:48Z

Looks good to me. Thanks for your contribution. ❤️

Thanks for the review, it was very helpful. Is it possible to see this feature in the release? What needs to be done for this?

ST-DDT · 2024-09-07T12:18:08Z

The maintainers have to review/merge it.

yidongnan

LGTM

batsura-sa force-pushed the feature/deadline_property branch from 5805901 to 72842c9 Compare August 3, 2024 12:52

ST-DDT requested changes Sep 2, 2024

View reviewed changes

ST-DDT added the enhancement A feature request or improvement label Sep 2, 2024

batsura-sa force-pushed the feature/deadline_property branch 4 times, most recently from 1094f3f to a19dbef Compare September 3, 2024 13:51

batsura-sa marked this pull request as draft September 3, 2024 14:30

Feat(deadline) add deadline property for client

28b073d

batsura-sa force-pushed the feature/deadline_property branch from a19dbef to 28b073d Compare September 3, 2024 16:26

batsura-sa marked this pull request as ready for review September 3, 2024 16:54

ST-DDT reviewed Sep 3, 2024

View reviewed changes

batsura-sa and others added 3 commits September 4, 2024 08:17

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

0da4da7

…pc/client/config/GrpcChannelProperties.java Co-authored-by: ST-DDT <[email protected]>

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

3b295c7

…pc/client/config/GrpcChannelProperties.java Co-authored-by: ST-DDT <[email protected]>

Feat(deadline) changed zero deadline behavior, javadoc corrections

e14b9fe

batsura-sa requested a review from ST-DDT September 4, 2024 10:19

ST-DDT reviewed Sep 4, 2024

View reviewed changes

...rter/src/main/java/net/devh/boot/grpc/client/interceptor/DeadlineSetupClientInterceptor.java Outdated Show resolved Hide resolved

...c/main/java/net/devh/boot/grpc/client/autoconfigure/GrpcClientDeadlineAutoConfiguration.java Outdated Show resolved Hide resolved

batsura-sa requested a review from ST-DDT September 4, 2024 14:33

batsura-sa force-pushed the feature/deadline_property branch from 18254e7 to 547045c Compare September 4, 2024 14:42

Feat(deadline) removed wasted DeadlineSetupClientInterceptor calls in…

7505c7d

… runtime

batsura-sa force-pushed the feature/deadline_property branch from 547045c to 7505c7d Compare September 4, 2024 14:43

ST-DDT reviewed Sep 4, 2024

View reviewed changes

...rter/src/main/java/net/devh/boot/grpc/client/interceptor/DeadlineSetupClientInterceptor.java Outdated Show resolved Hide resolved

...rter/src/main/java/net/devh/boot/grpc/client/interceptor/DeadlineSetupClientInterceptor.java Outdated Show resolved Hide resolved

batsura-sa and others added 2 commits September 5, 2024 08:15

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

42ebf40

…pc/client/interceptor/DeadlineSetupClientInterceptor.java Co-authored-by: ST-DDT <[email protected]>

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

809bc5b

…pc/client/interceptor/DeadlineSetupClientInterceptor.java Co-authored-by: ST-DDT <[email protected]>

batsura-sa requested a review from ST-DDT September 5, 2024 05:57

Feat(deadline) replaced bean deadlineStubTransformer with deadlineGrp…

a8bbe07

…cChannelConfigurer

batsura-sa force-pushed the feature/deadline_property branch from 66e240f to a8bbe07 Compare September 5, 2024 06:03

ST-DDT reviewed Sep 5, 2024

View reviewed changes

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

5a219a7

…pc/client/autoconfigure/GrpcClientDeadlineAutoConfiguration.java Co-authored-by: ST-DDT <[email protected]>

batsura-sa changed the title ~~Feat(timeout) add timeout property for client~~ Feat(timeout) add timeout property for the client Sep 6, 2024

Feat(timeout) changed the name of deadline property to timeout.

650a978

batsura-sa force-pushed the feature/deadline_property branch from 1aaef80 to 650a978 Compare September 6, 2024 06:55

ST-DDT reviewed Sep 6, 2024

View reviewed changes

batsura-sa and others added 5 commits September 6, 2024 12:11

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

0ebcc0a

…pc/client/autoconfigure/GrpcClientTimeoutAutoConfiguration.java Co-authored-by: ST-DDT <[email protected]>

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

6ab4d0d

…pc/client/autoconfigure/GrpcClientTimeoutAutoConfiguration.java Co-authored-by: ST-DDT <[email protected]>

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

e6403b6

…pc/client/interceptor/TimeoutSetupClientInterceptor.java Co-authored-by: ST-DDT <[email protected]>

Update grpc-client-spring-boot-starter/src/main/resources/META-INF/ad…

20dc197

…ditional-spring-configuration-metadata.json Co-authored-by: ST-DDT <[email protected]>

Feat(timeout) constructor and test changed.

9db6998

batsura-sa force-pushed the feature/deadline_property branch from 7cf859b to 9db6998 Compare September 6, 2024 09:48

batsura-sa requested a review from ST-DDT September 6, 2024 09:51

Feat(timeout) changed the name of timeout property to defaultRequestT…

102d09e

…imeout

batsura-sa force-pushed the feature/deadline_property branch from e7f1e3e to 102d09e Compare September 6, 2024 12:49

ST-DDT previously approved these changes Sep 6, 2024

View reviewed changes

...pring-boot-starter/src/main/java/net/devh/boot/grpc/client/config/GrpcChannelProperties.java Outdated Show resolved Hide resolved

Update grpc-client-spring-boot-starter/src/main/java/net/devh/boot/gr…

da2f32c

…pc/client/config/GrpcChannelProperties.java Co-authored-by: ST-DDT <[email protected]>

batsura-sa dismissed ST-DDT’s stale review via da2f32c September 7, 2024 01:48

batsura-sa changed the title ~~Feat(timeout) add timeout property for the client~~ Feat(defaultRequestTimeout) add defaultRequestTimeout property for the client Sep 7, 2024

ST-DDT approved these changes Sep 7, 2024

View reviewed changes

Merge branch 'master' into feature/deadline_property

c1b1ced

batsura-sa requested a review from ST-DDT October 27, 2024 13:45

yidongnan approved these changes Oct 27, 2024

View reviewed changes

yidongnan merged commit ee810d1 into grpc-ecosystem:master Oct 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(defaultRequestTimeout) add defaultRequestTimeout property for the client #1132

Feat(defaultRequestTimeout) add defaultRequestTimeout property for the client #1132

batsura-sa commented Aug 3, 2024 •

edited

Loading

ST-DDT left a comment

genuss commented Sep 5, 2024

batsura-sa commented Sep 6, 2024

batsura-sa commented Sep 6, 2024 •

edited

Loading

ST-DDT commented Sep 6, 2024

batsura-sa commented Sep 6, 2024 •

edited

Loading

ST-DDT commented Sep 6, 2024

batsura-sa commented Sep 6, 2024 •

edited

Loading

ST-DDT left a comment

batsura-sa commented Sep 7, 2024

ST-DDT commented Sep 7, 2024

yidongnan left a comment

Feat(defaultRequestTimeout) add defaultRequestTimeout property for the client #1132

Feat(defaultRequestTimeout) add defaultRequestTimeout property for the client #1132

Conversation

batsura-sa commented Aug 3, 2024 • edited Loading

ST-DDT left a comment

Choose a reason for hiding this comment

genuss commented Sep 5, 2024

batsura-sa commented Sep 6, 2024

batsura-sa commented Sep 6, 2024 • edited Loading

ST-DDT commented Sep 6, 2024

batsura-sa commented Sep 6, 2024 • edited Loading

ST-DDT commented Sep 6, 2024

batsura-sa commented Sep 6, 2024 • edited Loading

ST-DDT left a comment

Choose a reason for hiding this comment

batsura-sa commented Sep 7, 2024

ST-DDT commented Sep 7, 2024

yidongnan left a comment

Choose a reason for hiding this comment

batsura-sa commented Aug 3, 2024 •

edited

Loading

batsura-sa commented Sep 6, 2024 •

edited

Loading

batsura-sa commented Sep 6, 2024 •

edited

Loading

batsura-sa commented Sep 6, 2024 •

edited

Loading