Fix: Migrate off legacy JS/HTML APIs

[aran]

Fixes #715.

This includes a rebase of @minoic's #730 onto the latest master, along with a couple updates.

It also updates client_xhr_transport_test to avoid dart:html, performing some ceremony to work around the unavailability of the previous mock strategy.

[github-actions]

PR Health

Breaking changes ⚠️

Package	Change	Current Version	New Version	Needed Version	Looking good?
grpc	Breaking	4.0.1	4.0.2-wip	5.0.0 Got "4.0.2-wip" expected >= "5.0.0" (breaking changes)	⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

File	Coverage
lib/grpc_or_grpcweb.dart	💚 57 %
lib/src/client/transport/xhr_transport.dart	💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols
grpc	$1.Duration Any

This check can be disabled by tagging the PR with skip-leaking-check.

[aran]

RFC. There's quite a lot of boilerplate to work around the extension type extern for XMLHttpRequest. More work may be needed here to reimplement some of XMLHttpRequest for the test's expectations, if using this approach.

Help needed: the tests don't pass. I'm not sure how they're supposed to be run, since I run dart test -p chrome I still see errors about the unavailability of dart:js_interop, which is surprising, so something is broken in my mental model.

[aran]

@Moseum - anyone on maintainer side who could help shepherd this?

[mosuem]

I think we need to land #747 first, which has some failures at the moment. Happy to see this go through in general, thanks a lot for the initiative!

[aran]

@mosuem - should I temporarily remove this test from #747? I see that there is a CI failure in #747 that is related to this test.

[mosuem]

Help needed: the tests don't pass. I'm not sure how they're supposed to be run, since I run dart test -p chrome I still see errors about the unavailability of dart:js_interop, which is surprising, so something is broken in my mental model.

I see different failures locally - TypeError: null: type 'JSNull' is not a subtype of type 'JSObject'

[mosuem]

@mosuem - should I temporarily remove this test from #747? I see that there is a CI failure in #747 that is related to this test.

I would suggest to close #747 in favor of this PR, to fix the tests in the same PR as the other changes.

[aran]

Happy new year! Please let me know if there's anything else I can do to assist here.

[aran]

Gentle reminder this is here. Anyone who wants to use grpc + wasm mode needs this.

[mikebosland]

Aran, did you get the tests passing and your RFC addressed from your #750 (comment) above? I really appreciate all the work on this. Looking forward to being able to upgrade to WASM!

[mosuem]

Sorry for the long wait @aran ...

I tried to refactor the test to use the mocking as described in https://dart.dev/interop/js-interop/mock, but the lack of analyzer support for overrides and other small problems makes this not a nice solution IMO. So this LGTM! Please do adapt the PR title and description, and rebase the PR. Then we can merge it ASAP

[aran]

@mosuem updated. Let me know if there's anything else.

[mosuem]

Thanks for seeing this through!

[kevmoo]

Thank you!