Avoid CoWs #1530
Merged
Avoid CoWs #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't actually avoid a CoW here. We also don't need the 'modifying' workaround; the compiler is smarter now.
FranzBusch
approved these changes
Dec 12, 2022
| /// to `._modifying` allows us to avoid an extra reference to any heap allocated data and | ||
| /// therefore avoid a copy on write. | ||
| @inlinable | ||
| internal mutating func withStateAvoidingCoWs<Action>(_ body: (inout State) -> Action) -> Action { |
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
We didn't actually avoid a CoW here. We also don't need the 'modifying' workaround; the compiler is smarter now.
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
We didn't actually avoid a CoW here. We also don't need the 'modifying' workaround; the compiler is smarter now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't actually avoid a CoW here. We also don't need the 'modifying' workaround; the compiler is smarter now.