Skip to content

Remove unused code #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

Remove unused code #1549

merged 1 commit into from
Jan 5, 2023

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 5, 2023

Motivation:

We added a coalescing message framer in #1539 and #1546. The old framer is no longer used.

Modification:

  • Remote the now unused message writer and tests

Result:

Less unused code.

@glbrntt
Remove unused code
00c7cf0 
Motivation:

We added a coalescing message framer in grpc#1539 and grpc#1546. The old framer
is no longer used.

Modification:

- Remote the now unused message writer and tests

Result:

Less unused code.
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jan 5, 2023
@glbrntt glbrntt requested a review from Lukasa January 5, 2023 14:15
@glbrntt glbrntt enabled auto-merge (squash) January 5, 2023 14:20
@glbrntt glbrntt merged commit 71f87cc into grpc:main Jan 5, 2023
@glbrntt glbrntt deleted the gb-remove-unused-code branch January 6, 2023 13:15
WendellXY pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
@glbrntt @WendellXY
Remove unused code (grpc#1549)
a92b27a 
Motivation:

We added a coalescing message framer in grpc#1539 and grpc#1546. The old framer
is no longer used.

Modification:

- Remote the now unused message writer and tests

Result:

Less unused code.
pinlin168 pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
@glbrntt @pinlin168
Remove unused code (grpc#1549)
0b7fd99 
Motivation:

We added a coalescing message framer in grpc#1539 and grpc#1546. The old framer
is no longer used.

Modification:

- Remote the now unused message writer and tests

Result:

Less unused code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glbrntt @Lukasa