Server interceptors retain cycle #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: There's a code path through the ELF-based server handlers where the interceptor pipeline does not get `nil`'d out to break the reference cycle between the handler and the interceptors leading to a leak. This can happen if the RPC ends unexpectedtly. Modifications: - Break the retain cycle on the next event-loop tick; this gives any clean up code a chance to run first. - Break the retain cycle from the interceptors when they send end. Results: Fewer leaks.
Lukasa
approved these changes
Feb 3, 2023
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: There's a code path through the ELF-based server handlers where the interceptor pipeline does not get `nil`'d out to break the reference cycle between the handler and the interceptors leading to a leak. This can happen if the RPC ends unexpectedtly. Modifications: - Break the retain cycle on the next event-loop tick; this gives any clean up code a chance to run first. - Break the retain cycle from the interceptors when they send end. Results: Fewer leaks.
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: There's a code path through the ELF-based server handlers where the interceptor pipeline does not get `nil`'d out to break the reference cycle between the handler and the interceptors leading to a leak. This can happen if the RPC ends unexpectedtly. Modifications: - Break the retain cycle on the next event-loop tick; this gives any clean up code a chance to run first. - Break the retain cycle from the interceptors when they send end. Results: Fewer leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There's a code path through the ELF-based server handlers where the interceptor pipeline does not get
nil'd out to break the reference cycle between the handler and the interceptors leading to a leak. This can happen if the RPC ends unexpectedtly.Modifications:
Results:
Fewer leaks.