Allow custom verification callback to be configured for servers #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: NIOSSL allows users to override its certificate verification logic by setting a verification callback. gRPC allows clients to configure this but not servers. Modifications: - Add extra API to `GRPCTLSConfiguration` to allow custom verification callbacks to be set for servers. Result: Users can override the certificate verification logic on the server.
Lukasa
approved these changes
May 9, 2023
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
…#1595) Motivation: NIOSSL allows users to override its certificate verification logic by setting a verification callback. gRPC allows clients to configure this but not servers. Modifications: - Add extra API to `GRPCTLSConfiguration` to allow custom verification callbacks to be set for servers. Result: Users can override the certificate verification logic on the server.
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
…#1595) Motivation: NIOSSL allows users to override its certificate verification logic by setting a verification callback. gRPC allows clients to configure this but not servers. Modifications: - Add extra API to `GRPCTLSConfiguration` to allow custom verification callbacks to be set for servers. Result: Users can override the certificate verification logic on the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NIOSSL allows users to override its certificate verification logic by setting a verification callback. gRPC allows clients to configure this but not servers.
Modifications:
GRPCTLSConfigurationto allow custom verification callbacks to be set for servers.Result:
Users can override the certificate verification logic on the server.