Remove the gRPC Authors copyright header from generated swift files #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The common practice of code generators is not to apply their own copyright and license headers to generated files. Instead the output is owned by the owner of the input files and the executor of the code generator. Fixes grpc#1611. Modifications: Removed license header from file generator, test case files, and checks for generated file license headers in the CI sanity license-check. Results: End users of protoc-gen-grpc-swift will not have a Copyright by gRPC Authors added to the generated swift files from their own proto files. Related: The copyright headers could be added back via grpc#1610.
In process of setting up organization account for CLA. |
|
Thanks @kriswuollett -- looks like this was added way back and no one has questioned it since! Please tag me when you get your CLA sorted and I'll take a look. |
|
@glbrntt -- Thanks! I'm covered by the CLA now. |
glbrntt
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Thank @kriswuollett -- I don't suppose you're inclined to tackle #1610 as well?
I may take a look at it this week. It may be just a matter of copying the logic that already exists in the Swift Protobuf project, more or less. |
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
…rpc#1612) Motivation: The common practice of code generators is not to apply their own copyright and license headers to generated files. Instead the output is owned by the owner of the input files and the executor of the code generator. Fixes grpc#1611. Modifications: Removed license header from file generator, test case files, and checks for generated file license headers in the CI sanity license-check. Results: End users of protoc-gen-grpc-swift will not have a Copyright by gRPC Authors added to the generated swift files from their own proto files. Related: The copyright headers could be added back via grpc#1610.
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
…rpc#1612) Motivation: The common practice of code generators is not to apply their own copyright and license headers to generated files. Instead the output is owned by the owner of the input files and the executor of the code generator. Fixes grpc#1611. Modifications: Removed license header from file generator, test case files, and checks for generated file license headers in the CI sanity license-check. Results: End users of protoc-gen-grpc-swift will not have a Copyright by gRPC Authors added to the generated swift files from their own proto files. Related: The copyright headers could be added back via grpc#1610.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The common practice of code generators is not to apply their own copyright and license headers to generated files. Instead the output is owned by the owner of the input files and the executor of the code generator.
Fixes #1611.
Modifications:
Removed license header from file generator, test case files, and checks for generated file license headers in the CI sanity license-check.
Results:
End users of protoc-gen-grpc-swift will not have a Copyright by gRPC Authors added to the generated swift files from their own proto files.
Related:
The copyright headers could be added back via #1610.